Token: avoid unnecessary lookups in update_property_info() and added unit tests for it
#7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
updateprop-y
branch
7 times, most recently
from
74d74c9 to
d4f2034
Compare
firewave
changed the title
update_property_info() and added unit test for itupdate_property_info() and added unit tests for it
firewave
force-pushed
the
updateprop-y
branch
8 times, most recently
from
d0b0be7 to
73773fe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
before: after: |
danmar
approved these changes
Mar 18, 2025
lib/token.cpp
Outdated
| tokType(eKeyword); | ||
| update_property_isStandardType(); | ||
| if (mTokType != eType) // cannot be a control-float keyword when it is a type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.