Skip to content

Feature/converstion/googleai/1.16 #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v1.16
Choose a base branch
from

Conversation

ManuInNZ
Copy link

Signed-off-by: Emmanuel Auffray [email protected]

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs. N/A
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Just adding the doncs for the Google AI conversation models invocation.

Issue reference

N/A

@ManuInNZ ManuInNZ requested review from a team as code owners April 12, 2025 00:07
@ManuInNZ
Copy link
Author

@cicoyle ready for when the dapr/dapr#8572 is finished.

Based on 1.16 s requested my @msfussell

@ManuInNZ
Copy link
Author

created #4611

@msfussell
Copy link
Member

@ManuInNZ - Looks good. Also need to add this component and the Ollama one to this file https://github.com/dapr/docs/blob/v1.15/daprdocs/data/components/conversation/generic.yaml so these appear in the table https://docs.dapr.io/reference/components-reference/supported-conversation/.

@msfussell msfussell added this to the 1.16 milestone Apr 12, 2025
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once you have added the index file for both

@ManuInNZ
Copy link
Author

Done but I guess this one is still pending closing the PR on dapr itself.

@msfussell msfussell added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Apr 13, 2025
@ManuInNZ
Copy link
Author

@msfussell code pr merged by @yaron2
dapr/dapr@b365574
should be good to go
Thanks guys

@ManuInNZ
Copy link
Author

Just confirming code was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants