Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bulksubscribe http #478

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

feat: bulksubscribe support

cb26d03
Select commit
Loading
Failed to load commit list.
Open

feat: bulksubscribe http #478

feat: bulksubscribe support
cb26d03
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Dec 4, 2023 in 0s

66.05% (-2.92%) compared to ae8becf

View this Pull Request on Codecov

66.05% (-2.92%) compared to ae8becf

Details

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (ae8becf) 68.96% compared to head (cb26d03) 66.05%.
Report is 2 commits behind head on main.

❗ Current head cb26d03 differs from pull request most recent head 10d2c67. Consider uploading reports for the commit 10d2c67 to get more accurate results

Files Patch % Lines
service/http/topic.go 0.00% 104 Missing ⚠️
service/internal/topicregistrar.go 0.00% 40 Missing ⚠️
service/internal/topicsubscription.go 0.00% 11 Missing ⚠️
service/grpc/topic.go 47.36% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   68.96%   66.05%   -2.92%     
==========================================
  Files          34       35       +1     
  Lines        2707     3011     +304     
==========================================
+ Hits         1867     1989     +122     
- Misses        732      908     +176     
- Partials      108      114       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.