add purge options #638
Merged
add purge options #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 58.04% 62.46% +4.42%
==========================================
Files 55 56 +1
Lines 3568 4143 +575
==========================================
+ Hits 2071 2588 +517
- Misses 1375 1429 +54
- Partials 122 126 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Fabian Martinez <[email protected]>
mikeee
reviewed
Oct 18, 2024
workflow/client.go
Outdated
| @@ -205,9 +215,10 @@ func (c *Client) ResumeWorkflow(ctx context.Context, id, reason string) error { | |||
|
|
|||
| // PurgeWorkflow will purge a given workflow and return an error output. | |||
| // NOTE: The workflow must be in a terminated or completed state. | |||
| func (c *Client) PurgeWorkflow(ctx context.Context, id string) error { | |||
| // TODO missing upstream support for api.PurgeOptions | |||
There was a problem hiding this comment.
Looks like this comment can be removed with the merge of your PR upstream
Signed-off-by: Fabian Martinez <[email protected]>
mikeee
approved these changes
Oct 21, 2024
|
merge please |
|
@yaron2 Are you happy to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
blocked by microsoft/durabletask-go#82
closes #497
Issue reference
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: