Skip to content

chore: New task execution task id test #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented May 13, 2025

test how taskExecutionTaskId can be used for idempotency

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga changed the title [WIP] chore: New task execution task id test chore: New task execution task id test May 13, 2025
@javier-aliaga javier-aliaga marked this pull request as ready for review May 13, 2025 16:06
@javier-aliaga javier-aliaga requested review from a team as code owners May 13, 2025 16:06
@javier-aliaga javier-aliaga force-pushed the ja-task-idempotency-keys branch from fbe3b83 to 5fc7126 Compare May 15, 2025 08:48
test how taskExecutionTaskId can be used for idempotency

Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga force-pushed the ja-task-idempotency-keys branch from ae29385 to 45872ef Compare May 15, 2025 16:14
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.45%. Comparing base (d759c53) to head (45872ef).
Report is 143 commits behind head on master.

Files with missing lines Patch % Lines
...kflows/runtime/DefaultWorkflowActivityContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1352      +/-   ##
============================================
+ Coverage     76.91%   77.45%   +0.53%     
- Complexity     1592     1772     +180     
============================================
  Files           145      204      +59     
  Lines          4843     5446     +603     
  Branches        562      597      +35     
============================================
+ Hits           3725     4218     +493     
- Misses          821      907      +86     
- Partials        297      321      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! Mostly lgtm - mind adding a section or note about this somewhere in the daprdocs/?

Something as simple as saying use the ctx.getTaskExecutionKey() for xyz reasons will suffice.

Also, please ensure the header is added to every file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants