Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky integration test DemoActorReminderOnceImpl #553

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions daprdocs/content/en/js-sdk-docs/js-server/_index.md
Original file line number Diff line number Diff line change
@@ -112,8 +112,8 @@ const daprServer = new DaprServer({
serverPort: "50002", // App Port
serverHttp: myApp,
clientOptions: {
daprHost,
daprPort,
daprHost
daprPort
}
});

4 changes: 2 additions & 2 deletions src/actors/runtime/AbstractActor.ts
100644 → 100755
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ export default abstract class AbstractActor {
async registerActorReminder<_Type>(
reminderName: string,
dueTime: Temporal.Duration,
period: Temporal.Duration,
period?: Temporal.Duration,
ttl?: Temporal.Duration,
state?: any,
) {
@@ -115,7 +115,7 @@ export default abstract class AbstractActor {
timerName: string,
callback: string,
dueTime: Temporal.Duration,
period: Temporal.Duration,
period?: Temporal.Duration,
ttl?: Temporal.Duration,
state?: any,
) {
2 changes: 1 addition & 1 deletion src/types/ActorReminder.type.ts
100644 → 100755
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ limitations under the License.
import { Temporal } from "@js-temporal/polyfill";

export type ActorReminderType = {
period: Temporal.Duration; // e.g. 0h0m9s0ms
period?: Temporal.Duration; // e.g. 0h0m9s0ms
dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s
data?: any; // the data to pass
ttl?: Temporal.Duration; // e.g. 1m
2 changes: 1 addition & 1 deletion src/types/ActorTimer.type.ts
100644 → 100755
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ limitations under the License.
import { Temporal } from "@js-temporal/polyfill";

export type ActorTimerType = {
period: Temporal.Duration; // e.g. 0h0m9s0ms
period?: Temporal.Duration; // e.g. 0h0m9s0ms
dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s
data?: any; // the data to pass
ttl?: Temporal.Duration; // e.g. 1m