Skip to content

Comments

Pin google-protobuf to non-buggy version#640

Closed
tlund101 wants to merge 1 commit intodapr:mainfrom
tlund101:google-protobuf_bug
Closed

Pin google-protobuf to non-buggy version#640
tlund101 wants to merge 1 commit intodapr:mainfrom
tlund101:google-protobuf_bug

Conversation

@tlund101
Copy link
Contributor

@tlund101 tlund101 commented Oct 10, 2024

Description

google-protobuf@3.21.4 introduces a bug that results in secrets (and possibly other data) coming back as undefined via GRPC. This PR is a demo that adds an E2E test case and pins the google-protobuf version to a working version.

If you want to see the test fail, just unpin the library version and rebuild the lock file. I was not able to narrow down where in the protobuf library the issue is due to build issues, but I created issues in this repo as a stopgap and FYI. I figured a maintainer here may have a better insight as to where the problem lay.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 9, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Nov 9, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants