-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow quickstarts #1163
Conversation
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marc!! And look at those tests passing 🎉 just want to confirm that all the logic is still there to run an external event workflow in each example event if the quickstarts dont run it for the tests.
Signed-off-by: Marc Duiker <[email protected]>
29e00a0
to
28cbf2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marc!
Description
This PR updates the Workflow Quickstarts across all languages since they all had a different implementation (# of activities and logic) and different activity names.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1162
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: