Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow quickstarts #1163

Merged
merged 14 commits into from
Feb 14, 2025
Merged

Conversation

marcduiker
Copy link
Contributor

Description

This PR updates the Workflow Quickstarts across all languages since they all had a different implementation (# of activities and logic) and different activity names.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1162

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@marcduiker marcduiker marked this pull request as ready for review February 13, 2025 15:22
@marcduiker marcduiker requested review from a team as code owners February 13, 2025 15:22
Copy link

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc!! And look at those tests passing 🎉 just want to confirm that all the logic is still there to run an external event workflow in each example event if the quickstarts dont run it for the tests.

workflows/python/sdk/order-processor/app.py Show resolved Hide resolved
workflows/python/sdk/README.md Outdated Show resolved Hide resolved
Signed-off-by: Marc Duiker <[email protected]>
Copy link

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc!

@alicejgibbons alicejgibbons merged commit 38e9a81 into dapr:release-1.15 Feb 14, 2025
7 checks passed
@alicejgibbons alicejgibbons deleted the release-1.15 branch February 14, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants