Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ali Shobeyri #53

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open

Ali Shobeyri #53

wants to merge 73 commits into from

Conversation

sasssass
Copy link

Ali Shobeyri
Android

drflakelorenzgerman added 30 commits May 20, 2022 18:45
title :
a1700c6 
init
description :
1.init the project
2.add needed dependencies to build.gradle
title :
41afa55 
create modules
description :
1.create the following modules with their dependencies : core[base_ui,base_data,base_domain,navigator]
Merge branch 'master' of https://github.com/sasssass/tech-work-sample
914f1ab
title : base ui
f10ec96 
description :
1.create MotherFragment.kt and it's functions
2.add json lottie for loading
3.add colors
title : base ui + base domain
df9ac4e 
description :
1.create MotherViewModel.kt and it's functions
2.add cast mapper
3.add Domain
title : base data
4cffc0c 
description :
1.create a mapper for converting dto to domain
2.create a safeApi function for network
title : navigator
7fff4af 
description :
1.add basic tools for navigation system
title : navigator
82b285a 
description :
1.add 2 further features navigation files
title : navigator
85d65f7 
description :
1.add functionality for navigate between 2 modules (home and movie)
title : navigator + app
50eeccd 
description :
1.change policy of navigation system
2.refactor MainActivity.kt with dataBinding and add navigation to it
title : feature movie/home
c62e32b 
description :
1.add movie and home feature
2.separate movie module into separate modules
3.add gradle dependencies
title : feature movie
010580f 
description :
1.fix gradle
2.add dto model for discover movie api
title : feature movie
d53f2b1 
description :
1.add discover movie model for domain
2.add Mapper for data dto of discover movie
title : feature movie
740535b 
description :
1.add repository interface to domain
title : feature movie
58da682 
description :
1.change safeApi.kt and remove flow from it
2.add implementation of MovieRepository
3.add movie datasource
title : feature movie
66137bc 
description :
1.add DI for data layer
title : base domain
fc58f80 
description :
1.add Mother Usecase for base of other use cases
title : movie feature
4123b4b 
description :
1.add proper usecase for discovering movies
title : movie feature
b186a18 
description :
1.add global query param as api_key
title : movie feature / base data
4455495 
description :
1.add base test to base data
2.add test for data layer of movie
title : base data
94b1e00 
description :
1.add test for mapper
title : base data
c55ff51 
description :
1.add test for safeApi
title : home module
92d8b03 
description :
1.init the module
title : home module
198cca4 
description :
1.create Homefragment
title : home module
98c22de 
description :
1.fix ui of home fragment
2.add navigation system for home module
title : base ui
12164cc 
description :
1.add click extension for dataBinding
title : home module
5a6c6d9 
description :
1.connect home module to movie module
title : movie module
9d1cf41 
description :
1.add DI
2.add viewModel and proper logic for whole steps
3.add layout
4.connect to navigation system
title : base ui
3e8411a 
description :
1.add general adapter for lists
title : movie module
03fb701 
description :
1.implement the whole steps to getting the movies from API
drflakelorenzgerman added 30 commits May 22, 2022 10:12
title : home module
0ccdefc 
description :
1.add a button for navigating to offline page
title : movie module
02a6a69 
description :
1.change policy of getting data because now we have offline data too
title : movie module
580eefa 
description :
1.add viewModel for detail screen
title : shared data
87b3d06 
description :
1.change deleting function
title : movie module
c99c7a7 
description :
1.write proper methods for adding and deleting data from db
title : movie module + base ui
64b9e6a 
description :
1.chang movie detail fragment for deleting and saving movies
2.add active ext for views
3.add toast ext
title : shared data
013089a 
description :
1.add di for room
title : movie module
2c33a62 
description :
1.fix crash when you want to delete a favorite item
title : movie module
8b308fc 
description :
1.complete tests for movie module
2.fix bug and crashes
title : base data
dd17dfa 
description :
1.add comments
title : base domain
0a0e980 
description :
1.add comments
title : base ui
d46907d 
description :
1.add comments
title : base ui
cd540c6 
description :
1.add comments
title : navigator
aff3992 
description :
1.add comments
title : movie module
70cc93f 
description :
1.add empty state for list
title : movie module
d08e544 
description :
1.fix adult tag
title : read me
a16551c 
description :
1.add diagram
title : all modules
4cb0b90 
description :
1.reformat and organize codes
title : movie module - shared domain
ea0cfd9 
description :
1.add shared domain
2.refactor movie module and add top rated service
title : movie module - base ui
6d54534 
description :
1.change the UI, current one is not good
2.optimise base ui
title : movie module
808025c 
description :
1.change margins in fragment detail
title : movie module
483937b 
description :
1.optimise list
title : movie module
b605cc7 
description :
1.optimise UI
2.change tests depending on new UI
title : home module
791b60b 
description :
1.change UI
title : home module
f7017cc 
description :
1.change UI
title : home module
4a8b25f 
description :
1.change navigation policy
title : movie module
508c3cd 
description :
1.improve UI
title : base ui
76aaf21 
description :
1.improve UI
title : base ui
5469fcc 
description :
1.add Alert Dialog
2.show pop when an error happens
title : gradle
77bec51 
description :
1.refactor gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sasssass