Fix clippy lints and upgrade bitflags #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading bitflags was required to get rid of a clippy lint.
morrisonlevi
commented
Aug 27, 2023
Comment on lines
+45
to
+47
| #[allow(clippy::ptr_as_ptr)] | ||
| let recurse_info = | ||
| (&mut info.protection as *mut _) as mach::vm_region::vm_region_recurse_info_t; |
There was a problem hiding this comment.
I had to assign this to a variable because #[allow(clippy::ptr_as_ptr)] can't be applied to expressions.
darfink
force-pushed
the
master
branch
8 times, most recently
from
e8add20 to
65b427d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading bitflags was required to get rid of a clippy lint.
I tested this on a Mac M1 both in MacOS and on
debian:latestthrough docker (on the same machine, so aarch64) by doingcargo test -- --test-threads=1. I assume that test failures are expected when run in parallel because the regions from other tests may affect things like queries; if that's not expected... well then consider this a heads up ^_^The only downside I could find is that
bitflags2.X requires Rust 1.56 or newer. Since this project doesn't officially define a MSRV, I don't know if that's problematic.