Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: new module pixeldeblur #16368

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

weltyj
Copy link

@weltyj weltyj commented Feb 21, 2024

Also addressed style problems found by Pascal Obry on Feb 21., and cleaned out a little more unused code.

Another thought -- the "sharpen" module only works on the "L" component in Lab colorspace. This could do the same, but with an option to additionally deblur the "ab" components too. Personally I think the right way is to deblur all three components, in order to catch the cases where "L" is the same between some pixels but the "a" or "b" is more different than "L".

It would run about 2x faster if only deblurring the "L" component based on an extensive test of 1 image ;-).

@TurboGit TurboGit changed the title Pixeldeblur -- merged from 4.6.x branch. RFC: new module pixeldeblur Feb 22, 2024
@weltyj
Copy link
Author

weltyj commented Feb 22, 2024

Just another thought I had while out walking, the real genesis of this module was literally thinking about deblurring a slightly out of focus image or slightly soft lens. It is not intented to provide perceptual sharpening (like the traditional unsharp mask). Looking at how images are downscaled (via bilinear,bicubic,lanczos), and particularly how lanzcos will create slight halos, I really wonder if this should be in the processing chain before any pixel scaling happens -- as @jenshannoschwalm was thinking on the other PR.

Thanks all (especially @TurboGit) for your help/guidance.

FYI -- I'll be "off the grid" for a week.

Copy link

This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@TurboGit TurboGit marked this pull request as draft August 8, 2024 14:14
@TurboGit TurboGit added the difficulty: hard big changes across different parts of the code base label Sep 20, 2024
Copy link

This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard big changes across different parts of the code base no-pr-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants