add alert to hazeremoval if HQ processing is disabled #18387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HQ processing does not faithfully reproduce darkroom in darktable export result file when hazeremoval module is used. One example is this case; https://discuss.pixls.us/t/color-management-issue-for-specific-image/46940. Even with HQ processing enabled there are differences between what is rendered and what is exported. |
|
@ralfbrown : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate for addressing #18384.
The module's gui_update() function doesn't ever seem to be called, so right now the alert message's visibility is only set when first opening the image in darkroom.