Revert fixed panel header #18388
Merged
Revert fixed panel header #18388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TurboGit please revert #18323 with this PR
The approach I used has severe problems that our testing didn't reveal and that are not solvable without triggering other problems. #18381 is not one of those; it is easy to prevent (see #18379). But I haven't been able to solve #18375 (which happens when starting without any expanded headers) without many gtk-warning at startup. Even when the headers eventually show (you can press B to trigger a redraw) changing the font size causes many warnings on the command line again.
In the end, gtk just gets very confused when resizing widgets within event boxes after they have been realized and this confused internal state triggers warnings. I'll either have to abandon the idea or come with a different approach (maybe temporarily reparenting the topmost header, which is likely to open its own can of worms).
fixes #18375