Skip to content

Conversation

@Phemisters
Copy link
Contributor

Related darktabke issue: darktable-org/darktable#18897

Replace uses of camera manufacturer with camera maker. I'm not sure if the sentences now sometimes read a little oddly, but this makes it more consistent with darktable itself.

I have not changed other uses of manufacturer (e.g. printer or GPU manufacturer).

@elstoc
Copy link
Contributor

elstoc commented Nov 4, 2025

On reflection, while I'm ok with using the term "maker" in darktable itself (since the exif field is maker), reading the proposed changes, I think the term "manufacturer" is better in all these contexts in the documentation.

Perhaps the only exception might be the reference to the "maker ID" in which case I would surround it in quotes to make it clear we're quoting the exif field name.

The PR is much appreciated to allow me to see all the uses in context in one place.

@Phemisters Phemisters force-pushed the dt-replace-manufacturer-with-maker-doc branch from 254cc4b to 4698d2f Compare November 5, 2025 10:03
@Phemisters
Copy link
Contributor Author

Perhaps the only exception might be the reference to the "maker ID" in which case I would surround it in quotes to make it clear we're quoting the exif field name.

Updated as suggested.

@elstoc
Copy link
Contributor

elstoc commented Nov 5, 2025

LGTM, thanks!

@elstoc elstoc merged commit 4f03948 into darktable-org:master Nov 5, 2025
2 checks passed
@Phemisters Phemisters deleted the dt-replace-manufacturer-with-maker-doc branch November 5, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants