Skip to content

Update Cart.php and change array() to [] #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/Darryldecode/Cart/Cart.php
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function has($itemId)
* @return $this
* @throws InvalidItemException
*/
public function add($id, $name = null, $price = null, $quantity = null, $attributes = array(), $conditions = array(), $associatedModel = null)
public function add($id, $name = null, $price = null, $quantity = null, $attributes = [], $conditions = [], $associatedModel = null)
{
// if the first argument is an array,
// we will need to call add again
Expand All @@ -168,8 +168,8 @@ public function add($id, $name = null, $price = null, $quantity = null, $attribu
$item['name'],
$item['price'],
$item['quantity'],
Helpers::issetAndHasValueOrAssignDefault($item['attributes'], array()),
Helpers::issetAndHasValueOrAssignDefault($item['conditions'], array()),
Helpers::issetAndHasValueOrAssignDefault($item['attributes'], []),
Helpers::issetAndHasValueOrAssignDefault($item['conditions'], []),
Helpers::issetAndHasValueOrAssignDefault($item['associatedModel'], null)
);
}
Expand All @@ -179,8 +179,8 @@ public function add($id, $name = null, $price = null, $quantity = null, $attribu
$id['name'],
$id['price'],
$id['quantity'],
Helpers::issetAndHasValueOrAssignDefault($id['attributes'], array()),
Helpers::issetAndHasValueOrAssignDefault($id['conditions'], array()),
Helpers::issetAndHasValueOrAssignDefault($id['attributes'], []),
Helpers::issetAndHasValueOrAssignDefault($id['conditions'], []),
Helpers::issetAndHasValueOrAssignDefault($id['associatedModel'], null)
);
}
Expand Down Expand Up @@ -345,7 +345,7 @@ public function clear()

$this->session->put(
$this->sessionKeyCartItems,
array()
[]
);

$this->fireEvent('cleared');
Expand Down Expand Up @@ -506,7 +506,7 @@ public function removeItemCondition($itemId, $conditionName)

if ($item['conditions'] instanceof $conditionInstance) {
if ($tempConditionsHolder->getName() == $conditionName) {
$item['conditions'] = array();
$item['conditions'] = [];
}
}
}
Expand All @@ -532,7 +532,7 @@ public function clearItemConditions($itemId)
}

$this->update($itemId, array(
'conditions' => array()
'conditions' => []
));

return true;
Expand All @@ -549,7 +549,7 @@ public function clearCartConditions()
{
$this->session->put(
$this->sessionKeyCartConditions,
array()
[]
);
}

Expand Down