Do invalidation in Build instead of the asset graph
#3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
davidmorgan
force-pushed
the
invalidation
branch
13 times, most recently
from
73ea16a to
ea50c3b
Compare
davidmorgan
force-pushed
the
invalidation
branch
4 times, most recently
from
5f80d77 to
99c4580
Compare
jensjoha
approved these changes
May 5, 2025
| 'Build ${renderer.build(forInput, outputs)} because ' | ||
| '${renderer.id(firstNode.id)} was marked for build.', | ||
| 'Build ${renderer.build(primaryInput, outputs)} the outputs are ' | ||
| 'optional outputs than have become needed.', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Prior to this PR, invalidation uses a combination of: 1) walk rdeps to mark nodes as "needs building" or "needs checking" in the asset graph; and 2) propagate failures via rdeps in
Buildand 3) check deps inBuild.With this PR, rdeps are not used: invalidation happens only "in order". State that doesn't need serializing, the progress of the checking the current build, is moved out of the asset graph into the
Buildclass.Changes to
AssetNode:pendingBuildAction.lastKnownDigest->digestand document how it's used.isFailure, addresultwhich isnullfor not run,falsefor failed,truefor succeededwasOutputboolean: presence ofdigestindicates that it was output, because if there is an output, we immediately compute the digest; add getter checkingdigestinsteadDigest([])where a digest is needed to indicatewasOutputbut the content doesn't matter.