-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format record type annotations. #1346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. The tests are excellent. I made a few suggests on the code, but it's all minor stuff. This is a nice Christmas present to come back to. :)
Sending to @sigmundch for readability comments. Please review as a readability CL and add your feedback at go/dart-team-readability-feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As title says, formats record type annotations.
DelimitedListBuilder
for these since they work similarly to parameter lists, but not quite the same.The comments show how the splitting has changed for these, specifically in the case of:
which no longer splits like: