Format for elements. #1350
Merged
Format for elements. #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly uses the existing code for formatting the `for (...)` part of for statements, which I moved into PieceFactory so that it can be reused. In the process of adding tests for this, I noticed that a newline in the initializer of a for-in loop forced the `in` to split, which looks weird, so I fixed that too, for both for statements and for elements.
kallentu
approved these changes
Jan 4, 2024
natebosch
approved these changes
Jan 8, 2024
# Conflicts: # lib/src/front_end/ast_node_visitor.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly uses the existing code for formatting the
for (...)part of for statements, which I moved into PieceFactory so that it can be reused.In the process of adding tests for this, I noticed that a newline in the initializer of a for-in loop forced the
into split, which looks weird, so I fixed that too, for both for statements and for elements.I also added trivial support for postfix expressions because some of the for element tests use
i++. I didn't migrate the tests for those yet since they aren't really related to this change, so added a TODO to do that in a later PR.