Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inheritance doesn't match Implementors for ErrorDescription/DiagnosticsProperty (probably due to generics?) #2094

Closed
Hixie opened this issue Dec 15, 2019 · 2 comments · Fixed by #2358
Closed

Inheritance doesn't match Implementors for ErrorDescription/DiagnosticsProperty (probably due to generics?) #2094

Hixie opened this issue Dec 15, 2019 · 2 comments · Fixed by #2358
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link
Contributor

Hixie commented Dec 15, 2019

https://api.flutter.dev/flutter/foundation/ErrorDescription-class.html says it inherits from "DiagnosticsProperty", but https://api.flutter.dev/flutter/foundation/DiagnosticsProperty-class.html does not list "ErrorDescription" in its list of implementors. The lack of symmetry is confusing.
@jcollins-g jcollins-g added customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on Type: bug labels Dec 16, 2019
@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Type: bug labels Jul 15, 2020
@srawlins
Copy link
Member

srawlins commented Aug 7, 2020

Another possibility is that ErrorDescription actually extends _ErrorDiagnostic, which extends DiagnosticsProperty<List<Object>>. It's possible that the undocumented class in the middle is preventing the symmetry.

@srawlins
Copy link
Member

srawlins commented Aug 8, 2020

Likely the same as #1623, but I'm happy to keep both open. #1623 has details about the private link.

This was referenced Sep 17, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix implementation chain with internal private classes srawlins/dartdoc
3 participants
@srawlins @Hixie @jcollins-g