Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When accounting for direct implementors, skip over private ones #2354

Merged
merged 3 commits into from
Sep 18, 2020
Merged

When accounting for direct implementors, skip over private ones #2354

merged 3 commits into from
Sep 18, 2020

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Sep 17, 2020 •
edited
Loading

Fixes #1623

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Sep 17, 2020
@srawlins srawlins requested a review from jcollins-g September 17, 2020 21:55
jcollins-g
jcollins-g approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@srawlins srawlins merged commit f5985ce into dart-lang:master Sep 18, 2020
@srawlins srawlins deleted the skip-private-implementors branch September 18, 2020 16:40
@Hixie
Copy link
Contributor

Hixie commented Sep 22, 2020

Woot!

@jcollins-g jcollins-g mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uint8List inherits from TypedData but docs don't show it
4 participants
@srawlins @Hixie @jcollins-g @googlebot