Skip to content

Include embedder SDK libraries only if the default library is SDK library too. #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isoos wants to merge 1 commit into from
Closed

Include embedder SDK libraries only if the default library is SDK library too. #1962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 0.28.3+3
* Fix code highlighting in Dart after string interpolation(#1946, #1948) by
updating the highlightjs dependency.
updating the highlightjs dependency.
* Fix: Include embedded SDK libraries only if the default library is SDK library too.

## 0.28.3+2
* Support the latest version of `package:html`.
Expand Down
12 changes: 8 additions & 4 deletions lib/src/model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6013,10 +6013,14 @@ class Package extends LibraryContainer
/// was not excluded on the command line.
bool get isLocal {
if (_isLocal == null) {
_isLocal = (packageMeta == packageGraph.packageMeta ||
packageGraph.hasEmbedderSdk && packageMeta.isSdk ||
packageGraph.config.autoIncludeDependencies) &&
!packageGraph.config.isPackageExcluded(name);
final isDefault = packageMeta == packageGraph.packageMeta;
final partOfEmbedderSdk = packageGraph.hasEmbedderSdk &&
packageGraph.packageMeta.isSdk &&
packageMeta.isSdk;
final autoInclude = packageGraph.config.autoIncludeDependencies;
final included = isDefault || partOfEmbedderSdk || autoInclude;
final excluded = packageGraph.config.isPackageExcluded(name);
_isLocal = included && !excluded;
}
return _isLocal;
}
Expand Down