Skip to content

Fix version parsing error for new dev builds #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2020
Merged

Fix version parsing error for new dev builds #2186

merged 3 commits into from
Apr 20, 2020

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Apr 20, 2020 •
edited
Loading

Fixes #2185.

Allow more flexibility in how "dev" versions are parsed. This will allow dartdoc to conform to dart-lang/sdk#40687 (comment) for the SDK.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 20, 2020
@coveralls
Copy link

coveralls commented Apr 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 91.707% when pulling 07da71d on fix-versioning into 2fe0397 on master.

@jcollins-g jcollins-g merged commit d647980 into master Apr 20, 2020
@jcollins-g jcollins-g deleted the fix-versioning branch April 27, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

@stereotype441 stereotype441 Awaiting requested review from stereotype441

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dartdoc exception on 2.9.0-1.0.dev
4 participants
@jcollins-g @coveralls @srawlins @googlebot