Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null for unnamed extension methods #2197

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Allow null for unnamed extension methods #2197

merged 1 commit into from
Apr 29, 2020

Conversation

jcollins-g
Copy link
Contributor

The head analyzer returns null for an unnamed extension method.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 28, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 91.664% when pulling 63faeac on fix-head-sdk-unnamed-extension into 0448e5f on master.

scheglov
scheglov approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@scheglov scheglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
Sorry, it was changed yesterday.

@jcollins-g jcollins-g merged commit 07f667c into master Apr 29, 2020
@kevmoo kevmoo deleted the fix-head-sdk-unnamed-extension branch April 29, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheglov scheglov scheglov approved these changes

@MichaelRFairhurst MichaelRFairhurst Awaiting requested review from MichaelRFairhurst

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @scheglov @googlebot