Override packagemeta using a provider rather than statically #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
May 26, 2020
There was a problem hiding this comment.
This is so much better, thanks.
It occurs to me that "PubPackageMeta" is a bit of a misnomer since it covers more than just pub packages. What we really intend here seems to be "PackageMeta for the ordinary Dart open source ecosystem".... but I have no alternative as to a better name so pub is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to the CL that enabled configuring
PackageMetaconstruction. We now inject a provider rather than statically overriding factories.