Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by 22% via memoization. #2255

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Improve performance by 22% via memoization. #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
221bfb2
Improve performance via memoization.
srawlins Jul 8, 2020
f4b1e16
simplify
srawlins Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/src/model/model_element.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,12 +710,11 @@ abstract class ModelElement extends Canonicalization
var confidence = highestScore - secondHighestScore;
var message =
'${candidateLibraries.map((l) => l.name)} -> ${candidateLibraries.last.name} (confidence ${confidence.toStringAsPrecision(4)})';
var debugLines = <String>[];
debugLines.addAll(scoredCandidates.map((s) => '${s.toString()}'));

if (confidence < config.ambiguousReexportScorerMinConfidence) {
warnable.warn(PackageWarning.ambiguousReexport,
message: message, extendedDebug: debugLines);
message: message,
extendedDebug: scoredCandidates.map((s) => '$s'));
}
}
if (candidateLibraries.isNotEmpty) {
Expand Down Expand Up @@ -972,8 +971,10 @@ abstract class ModelElement extends Canonicalization
_modelType = type;
}

String _name;

@override
String get name => element.name;
String get name => _name ??= element.name;

@override
String get oneLineDoc => _documentation.asOneLiner;
Expand Down
9 changes: 5 additions & 4 deletions lib/src/model/package.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,17 @@ class Package extends LibraryContainer

String get filePath => 'index.$fileType';

String _fileType;

String get fileType {
// TODO(jdkoren): Provide a way to determine file type of a remote package's
// docs. Perhaps make this configurable through dartdoc options.
// In theory, a remote package could be documented in any supported format.
// In practice, devs depend on Dart, Flutter, and/or packages fetched
// from pub.dev, and we know that all of those use html docs.
if (package.documentedWhere == DocumentLocation.remote) {
return 'html';
}
return config.format;
return _fileType ??= (package.documentedWhere == DocumentLocation.remote)
? 'html'
: config.format;
}

@override
Expand Down