Performance improvements and refactoring #2259
Merged
+125
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When documenting the camera Flutter plugin, these changes reduce the time to
document from 52 seconds to 51 seconds.
Much of this speedup likely came from memoizing Package.documentedWhere, which
has a few expensive calls like `linkToRemote` and `linkToUrl`. Additionally
ModelElement.locationPieces is now memoized.
The rest is a few refactorings:
* ModelElement.canonicalLibrary:
* Refactor most of the complexity of ModelElement.canonicalLibrary into a
new private method.
* Don't compute topLevelElement until you need it.
* Short circuit if `definingLibrary.exportedInLibraries` is null.
* Reduce nesting
* Create warning message only if it will be used.
* Prefer for loops over Iterable.forEach.
scheglov
approved these changes
Jul 10, 2020
|
Yeah I was trying a bunch of little things, cleaning code, and none of it made it worse, and I think the code is more idiomatic and maintainable so, might as well cut and commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When documenting the camera Flutter plugin, these changes reduce the time to document from 52 seconds to 51 seconds.
Much of this speedup likely came from memoizing Package.documentedWhere, which has a few expensive calls like
linkToRemoteandlinkToUrl. Additionally ModelElement.locationPieces is now memoized.The rest is a few categorical refactorings:
definingLibrary.exportedInLibrariesis null.