-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dartdoc's dep on package:quiver #2287
Conversation
I'm not sure why, but the travis builds for dartdoc aren't completing for me:
|
Haha I had the same thing with Travis this morning. :( Something with 2.9.0 final perhaps. |
Each time I tried to remove the lazyConcat code, dartdoc got markedly slower :( It seems super weird. Have you benchmarked this PR? I just used |
I haven't tried benchmarking this, but this is the exact impl. of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see now. I love it. Love the new tests.
Thanks! I'll circle back to this in a bit - just want to validate that the CI failures aren't related to the work in this PR. |
Closing in favor of #2305. |
package:cli_util
@srawlins - this PR is a bit speculative. In dartdoc we're importing package:quiver - a fairly large package - but only using a very small bit of its API. I'd definitely welcome your thoughts here -