Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve newline following {@endtemplate}. #2289

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Aug 8, 2020

Additionally introduce (some of?) the first unit tests. These live
in test/unit/ for now. This includes a new dev dependency on mockito.

Fixes #1848

Additionally introduce (some of?) the first unit tests. These live
in test/unit/ for now. This includes a new dev dependency on mockito.
@srawlins srawlins requested a review from devoncarew August 8, 2020 07:07
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Aug 8, 2020
@@ -0,0 +1,191 @@
import 'dart:io' show Directory;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copyright

@srawlins
Copy link
Member Author

Side-stepping the flutter bot timeout. This is affecting all PRs.

@srawlins srawlins merged commit f740dfc into dart-lang:master Aug 11, 2020
@srawlins srawlins deleted the fix-1848 branch August 11, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaks after template are lost
3 participants