Privatize some of the interface of Library #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
lgtm!
Note that some portion of the dartdoc API is consumed internally (I don't know that this PR affects that but wanted to mention it). You can look back through @mehmetf 's recent PRs into dartdoc to get a sense of what API surface area is used.
|
Yes, I'm trying to sync dartdoc internally on the regular now, to catch any conflicts early. Glad to have an internal customer! |
|
Side-stepping the flutter timeout; all PRs feature this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library.fromLibraryResultto be a factory constructorLibrary. _exportedAndLocalElementsfrom aList<Element>to afinal Set<Element>Library.getDefinedElements,Library.getLibraryName, and getterLibrary.allOriginalModelElementNames./*late final*/.