Improve error when FLUTTER_ROOT is missing. #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-do, sort of, of dart-lang#1714, which was broken in dart-lang#2190.
|
Interesting - when does dartdoc run |
|
It looks like it only runs it when |
Interesting. We should likely change this to hard fail if some set of conditions aren't met, instead of falling back on running pub for the user. |
|
Looks like analyzer is broken at HEAD (~0.40.1-dev) |
|
@bwilkerson There might be an issue with |
|
@scheglov Travis turned green. |
|
@scheglov This is ready for review. |
scheglov
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-do, sort of, of #1714, which was broken in #2190. Fixes #2279