Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some fields which erroneously reference "default" constructors. #2330

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Sep 3, 2020

A "default constructor" is an unnamed, zero-arg constructor. But the
constructors being referenced in these fields are just "unnamed."

  • Deprecated Class.defaultConstructor: use Class.unnamedConstructor.
  • Deprecated Constructor.isDefaultConstructor: use
    Constructor.isUnnamedConstructor.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Sep 3, 2020
A "default constructor" is an unnamed, zero-arg constructor. But the
constructors being referenced in these fields are just "unnamed."

* Deprecated `Class.defaultConstructor`: use `Class.unnamedConstructor`.
* Deprecated `Constructor.isDefaultConstructor`: use
  `Constructor.isUnnamedConstructor`.
Copy link
Member

@stereotype441 stereotype441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srawlins srawlins merged commit 8b1e6bf into dart-lang:master Sep 3, 2020
@srawlins srawlins deleted the fix-default-text branch September 3, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants