Skip to content

remove some unused dependencies #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

remove some unused dependencies #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/src/logging.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:async';
import 'dart:convert';
import 'dart:io' show stderr, stdout;
Expand All @@ -6,10 +10,6 @@ import 'package:analyzer/file_system/file_system.dart';
import 'package:cli_util/cli_logging.dart' show Ansi;
import 'package:dartdoc/dartdoc.dart';
import 'package:dartdoc/src/dartdoc_options.dart';
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a head-scratcher...

// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:logging/logging.dart';

final _logger = Logger('dartdoc');
Expand Down Expand Up @@ -128,7 +128,9 @@ void startLogging(LoggingContext config) {

abstract class LoggingContext implements DartdocOptionContextBase {
bool get json => optionSet['json'].valueAt(context);

bool get showProgress => optionSet['showProgress'].valueAt(context);

bool get quiet => optionSet['quiet'].valueAt(context);
}

Expand Down
6 changes: 0 additions & 6 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,13 @@ dependencies:
cli_util: '>=0.1.4 <0.3.0'
crypto: ^2.0.6
html: '>=0.12.1 <0.15.0'
# We don't use http_parser directly; this dep exists to ensure that we get at
# least version 3.0.3 to work around an issue with 3.0.2.
http_parser: '>=3.0.3 <4.0.0'
logging: ^0.11.3+1
process: ^3.0.5
markdown: ^2.1.5
meta: ^1.1.8
mustache: ^1.1.0
package_config: '>=0.1.5 <2.0.0'
path: ^1.3.0
pub_semver: ^1.3.7
stack_trace: ^1.4.2
yaml: ^2.1.0

dev_dependencies:
Expand All @@ -36,7 +31,6 @@ dev_dependencies:
dhttpd: ^3.0.0
glob: ^1.1.5
grinder: ^0.8.2
io: ^0.3.0
http: ^0.12.0
mockito: ^4.1.1
pedantic: ^1.9.0
Expand Down
6 changes: 3 additions & 3 deletions tool/grind.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import 'package:analyzer/file_system/physical_file_system.dart';
import 'package:dartdoc/src/io_utils.dart';
import 'package:dartdoc/src/package_meta.dart';
import 'package:grinder/grinder.dart';
import 'package:io/io.dart';
import 'package:path/path.dart' as path;
import 'package:yaml/yaml.dart' as yaml;

Expand Down Expand Up @@ -130,6 +129,7 @@ Directory get testPackageDocsDir =>
_testPackageDocsDir ??= createTempSync('test_package');

Directory _testPackageExperimentsDocsDir;

Directory get testPackageExperimentsDocsDir =>
_testPackageExperimentsDocsDir ??=
createTempSync('test_package_experiments');
Expand Down Expand Up @@ -761,7 +761,7 @@ class FlutterRepo {
static Future<FlutterRepo> copyFromExistingFlutterRepo(
FlutterRepo origRepo, String flutterPath, Map<String, String> env,
[String label]) async {
await copyPath(origRepo.flutterPath, flutterPath);
copy(Directory(origRepo.flutterPath), Directory(flutterPath));
var flutterRepo = FlutterRepo._(flutterPath, env, label);
return flutterRepo;
}
Expand Down Expand Up @@ -826,7 +826,7 @@ Future<String> _buildPubPackageDocs(
var pubPackageDirOrig =
cache.listSync().firstWhere((e) => e.path.contains(pubPackageName));
var pubPackageDir = Directory.systemTemp.createTempSync(pubPackageName);
await copyPath(pubPackageDirOrig.path, pubPackageDir.path);
copy(pubPackageDirOrig, pubPackageDir);

if (packageMetaProvider
.fromDir(PhysicalResourceProvider.INSTANCE.getFolder(pubPackageDir.path))
Expand Down