Refactor comment_processable_test to not use so many mocks. #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the only mock is the file system, and the MockSdk. This does make the tests slower (re-analyzing the mock SDK each go), but they're certainly cleaner. Also move more tests from end2end, mostly @animation and @inject-html tests.
scheglov
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the only mock is the file system, and the MockSdk. This does make the tests
slower (re-analyzing the mock SDK each go), but they're certainly cleaner.
Also move more tests from end2end, mostly @animation and @inject-html tests.
Helps with #2295