Changes to adapt to vscode and fix a deadlock #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2302.
Corrects a deadlock caused by MultiFutureTracker. I suspect something subtle changed recently making a deadlock more likely, but the code was always wrong. Hopefully, it is more correct now.
Add
.vscodeto .gitignore.Also, move the flutter plugin one directory level down to avoid Flutter autodetection by the VSCode dart extension. Not a great solution, but there seems to be no way to override the autodetect for the rest of the package otherwise. To operate VSCode with Flutter enabled (perhaps, to edit the flutter plugin test package), you can use a multi-root workspace and add the test package as a separate root.