Skip to content

Fix missing null checks for YAML data #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix missing null checks for YAML data #2441

merged 1 commit into from
Dec 1, 2020

Conversation

jcollins-g
Copy link
Contributor

Fixes #2378.

While #2348 eliminated the null dereference exception on path, there were some other unfortunate things going on in the YAML handling where we weren't checking nulls that show up right behind.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Nov 30, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.379% when pulling fef762c on fix-null-yaml-data into d79877d on master.

@jcollins-g jcollins-g requested a review from srawlins November 30, 2020 19:11
@jcollins-g jcollins-g mentioned this pull request Nov 30, 2020
Closed
@jcollins-g jcollins-g merged commit ffa4004 into master Dec 1, 2020
@jcollins-g jcollins-g deleted the fix-null-yaml-data branch August 11, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dartdoc throws fatal exception when package refers to another (non-pub) package
3 participants
@jcollins-g @coveralls @srawlins