Added cache control for http request within BrowserClient

[seifibrahim32]

Added cache control for BrowserClient and passed 85 conformance tests including fixes in tests for html runtime.

[brianquinlan]

Please add tests for this. There are cache testing examples here:

http/pkgs/cronet_http/example/integration_test/cronet_configuration_test.dart

Line 12 in c7cc4f8

void testCache() {

[brianquinlan]

Remember to write tests! ;-)

[github-actions]

PR Health

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

File	Coverage
pkgs/http/lib/browser_client.dart	💔 Not covered
pkgs/http/lib/src/browser_client.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/http/example/main.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart

[seifibrahim32]

@brianquinlan I will add tests but, I want to make sure that everything goes good within the design.
@kevmoo I am thinking of changing from String to CacheOption and we get the String type within the enum.

[seifibrahim32]

@brianquinlan Hello, I am back once again.
The tests are ready..
Waiting to hear back from you.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:cronet_http	1.3.3-wip	WIP (no publish necessary)
package:cupertino_http	2.0.3-wip	WIP (no publish necessary)
package:http	1.5.0	ready to publish	http-v1.5.0
package:http2	2.3.2-wip	WIP (no publish necessary)
package:http_multi_server	3.2.2	already published at pub.dev
package:http_parser	4.1.2	already published at pub.dev
package:http_profile	0.1.1-wip	WIP (no publish necessary)
package:ok_http	0.1.1-wip	WIP (no publish necessary)
package:web_socket	0.1.6	already published at pub.dev
package:web_socket_channel	3.0.2	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[brianquinlan]

You are only doing a single request here so I'm not sure how this is testing the caching behavior.

[seifibrahim32]

Nope, it is two GET requests, when it is set to default type it is cached once.

[seifibrahim32]

I guess, I need to drain the request so, I can see the difference.

[brianquinlan]

Shouldn't numOfRequests always be 2?

[seifibrahim32]

Yes, see most of other tests.

[seifibrahim32]

Do you have other suggestions regarding the tests? @brianquinlan