Skip to content

Http-parser: Make CaseInsensitiveMap be extension type. #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Http-parser: Make CaseInsensitiveMap be extension type. #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0631867
Http-parser: Make CaseInsensitiveMap be extension type.
lrhn Feb 12, 2025
8ae9f4b
Down upgrade lints yet. Something depends on something.
lrhn Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkgs/http_parser/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 4.1.3

* Makes `CaseInsensitiveMap` an extension type.
Allows `package:collection` to make the class `final`.

## 4.1.2

* Fixed a bug where parsing quoted header values could require a regex to
Expand Down
19 changes: 10 additions & 9 deletions pkgs/http_parser/lib/src/case_insensitive_map.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,20 @@ import 'package:collection/collection.dart';
/// A map from case-insensitive strings to values.
///
/// Much of HTTP is case-insensitive, so this is useful to have pre-defined.
class CaseInsensitiveMap<V> extends CanonicalizedMap<String, String, V> {
extension type CaseInsensitiveMap<V>._(Map<String, V> _)
implements Map<String, V> {
/// Creates an empty case-insensitive map.
CaseInsensitiveMap() : super(_canonicalizer);
CaseInsensitiveMap()
: this._(CanonicalizedMap<String, String, V>(_canonicalize));

/// Creates a case-insensitive map that is initialized with the key/value
/// pairs of [other].
/// Creates a case-insensitive map initialized with the entries of [other].
CaseInsensitiveMap.from(Map<String, V> other)
: super.from(other, _canonicalizer);
: this._(CanonicalizedMap<String, String, V>.from(other, _canonicalize));

/// Creates a case-insensitive map that is initialized with the key/value
/// pairs of [entries].
/// Creates a case-insensitive map initialized with the [entries].
CaseInsensitiveMap.fromEntries(Iterable<MapEntry<String, V>> entries)
: super.fromEntries(entries, _canonicalizer);
: this._(CanonicalizedMap<String, String, V>.fromEntries(
entries, _canonicalize));

static String _canonicalizer(String key) => key.toLowerCase();
static String _canonicalize(String key) => key.toLowerCase();
}
4 changes: 2 additions & 2 deletions pkgs/http_parser/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: http_parser
version: 4.1.2
version: 4.1.3
description: >-
A platform-independent package for parsing and serializing HTTP formats.
repository: https://github.com/dart-lang/http/tree/master/pkgs/http_parser
Expand All @@ -14,5 +14,5 @@ dependencies:
typed_data: ^1.3.0

dev_dependencies:
dart_flutter_team_lints: ^3.0.0
dart_flutter_team_lints: ^3.1.0
test: ^1.16.6
Loading