Skip to content

[jnigen] Remove TypeUsage indirection #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2025
Merged

[jnigen] Remove TypeUsage indirection #2186

merged 6 commits into from
Apr 11, 2025

Conversation

HosseinYousefi
Copy link
Member

@HosseinYousefi HosseinYousefi commented Apr 10, 2025

Closes #2010.

Previously we had a TypeUsage class that really didn't do anything other than nest a ReferredType because json_serializable doens't support union types (as ReferredType could be PrimtiveType, DeclaredType, ...).

This is unnecessary as we can simply parse that level manually instead of relying on json_serializable's codegen.

Unrelated change: more descriptive doc comments that includes the original type of methods and fields including their generic types.

Copy link

github-actions bot commented Apr 10, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@HosseinYousefi
Copy link
Member Author

HosseinYousefi commented Apr 10, 2025

The ubuntu beta test failure is not related to this PR, the sources are not changed other than doc comments.

Opened another issue for this flake: #2188

@HosseinYousefi HosseinYousefi merged commit 42dd764 into main Apr 11, 2025
26 of 27 checks passed
@HosseinYousefi HosseinYousefi deleted the referred-type branch April 11, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jnigen] Remove the TypeUsage indirection
2 participants