Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edit pass over /src/***.md #1474

Merged
merged 6 commits into from
Apr 23, 2019
Merged

Copy edit pass over /src/***.md #1474

merged 6 commits into from
Apr 23, 2019

Conversation

kwalrath
Copy link
Contributor

@kwalrath kwalrath commented Apr 22, 2019

My aim was to fix the YAML at the top of every file, in particular titles. As you might expect, the scope grew, since this was the first time I'd edited every single .md file.

Use includes for web & server tutorials, so we can reuse the cards in /tutorials/web & tutorials/server.

Also regularize page titles.
Improve titles, tweak text.
Edited every .md file under the /src directory.
For most pages, I just made the titles look right, but I made some other changes I'll describe later.
(For now, I just want to back up my work!)
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Apr 22, 2019
@kwalrath
Copy link
Contributor Author

kwalrath commented Apr 23, 2019

Here are the changes I made. I looked at every .md file under src and did the following:

  • Reviewed the YAML at the top of each file. As appropriate:
    • Made the title sentence case; renamed if necessary to match the IA.
    • Removed unnecessary quotation marks.
    • Removed unnecessary key:value pairs (e.g. some occurrences of layout, obsolete, css, permalink). When I removed obsolete, sometimes added a note with caveats/background.
    • Improved descriptions.
  • Labeled to-do items that I noticed:
    • Added "TBD" when a page absolutely needs to be updated (or question answered) before we ship this.
    • Added "PENDING" when we should make a change, but it isn't as urgent.
  • Tweaked the sidenav, adding /tools/pub/environment-variables and /tools/dartpad, and adding to & organizing Resources.
  • Removed some very obsolete/unused/unlinked pages:
    • reflections-with-mirrors
    • author pages
    • synonyms placeholder
  • Fixed some but not all references to page names in content. We'll need another pass for this in another PR.
  • Revamped some tutorial pages:
    • Created include files for content used in multiple pages: server-tutorials, web-tutorials. Could do more here.
    • Revamped the tutorial index (/tutorials) and added server-side & web tutorials to the page.
    • Added /tutorials/web (for URL walkers).
    • Added more context for low-level HTML tutorials.
  • Rewrote /tutorials/server/get-started to not be Webstorm-specific.
  • Made changes to some other non-linked-to pages (ones people usually encounter by walking up the URL tree), such as articles/language and articles/libraries. Added /web.
  • Updated /community, removing links to disused destinations.
  • Made some other content changes to individual pages, including the spec page, /guides/libraries/futures-error-handling, ... I tried to restrain myself.

@kwalrath kwalrath requested a review from mit-mit April 23, 2019 00:10
@kwalrath kwalrath changed the title [WIP] Copy edit pass over /src/***.md Copy edit pass over /src/***.md Apr 23, 2019
title: Articles
description: "Read about the Dart language and tools with this collection of articles, style guides, and more."
permalink: /articles
description: Read early articles about the Dart language and libraries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider not having this page? It's already marked Obsolete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we delete or move every file under /articles, then yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't realize that this was the only way of getting to them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually link to this page or most of the articles, iirc, but if people find an article, they're likely to walk up the URL chain. We don't have to list articles we don't want people to visit, but I'd like to have a page to avoid unnecessary 404s.

---

_Written by John McCutchan <br>
October 2012 (updated November 2012; note updated July 2018)_

<aside class="alert alert-warning" markdown="1">
This article still has valid information, but it was initially targeted for
This article was initially targeted for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should retire this, and file a bug to produce a more contemporary version later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #1475 and have removed it from my repo.

@@ -0,0 +1,17 @@
The following tutorials show how to develop scripts, command-line apps,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are going to have to split this into command-line apps, and server apps. But we can do that in a later PR after more planning and discussion.

need to set the path to the SDK.
You can find the instructions at
[Configuring Dart support]({{site.webdev}}/tools/webstorm#configuring-dart-support).
If you're using a Dart-savvy IDE, follow these instructions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider linking 'Dart-savvy IDE' to some page that lists IDEs that are

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in my repo.

@@ -42,4 +42,13 @@ $ dartfmt --help

{% comment %}
[PENDING: Add info on commonly used options.]

[PENDING: Advocate using this! Perhaps steal the first paragraph from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this a while back; may serve as inspiration
https://flutter.dev/docs/development/tools/formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all of this content is applicable to Dart formatting, in general. Maybe we should have includes under site-shared? Or move this information to the Dart site?

I thought there might be a lint or other tool to help with trailing commas, but looking at the reported issues (dart-lang/dart_style#753, dart-lang/sdk#27086), it's apparently a hard problem to solve.

@kwalrath
Copy link
Contributor Author

@mit-mit I plan to commit this once the build passes, unless you think that's a problem.

@kwalrath kwalrath merged commit f93b3a4 into dash Apr 23, 2019
@kwalrath kwalrath deleted the kw-dash-titles branch April 23, 2019 20:58
isoos pushed a commit to isoos/dart-lang-site-www that referenced this pull request Apr 25, 2019
I looked at every .md file under src and did the following:

* Reviewed the YAML at the top of each file. As appropriate:
  * Made the title sentence case; renamed if necessary to match the IA.
  * Removed unnecessary quotation marks.
  * Removed unnecessary key:value pairs (e.g. some occurrences of layout, obsolete, css, permalink). When I removed obsolete, sometimes added a note with caveats/background.
  * Improved descriptions.
* Labeled to-do items that I noticed:
  * Added "TBD" when a page absolutely needs to be updated (or question answered) before we ship this.
  * Added "PENDING" when we should make a change, but it isn't as urgent.
* Tweaked the sidenav, adding /tools/pub/environment-variables and /tools/dartpad, and adding to  & organizing Resources.
* Removed some very obsolete/unused/unlinked pages: 
  * reflections-with-mirrors
  * author pages
  * synonyms placeholder
* Fixed some but not all references to page names in content. We'll need another pass for this in another PR.
* Revamped some tutorial pages:
  * Created include files for content used in multiple pages: server-tutorials, web-tutorials. Could do more here.
  * Revamped the tutorial index (/tutorials) and added server-side & web tutorials to the page.
  * Added /tutorials/web (for URL walkers).
  * Added more context for low-level HTML tutorials.
* Rewrote /tutorials/server/get-started to not be Webstorm-specific.
* Made changes to some other non-linked-to pages (ones people usually encounter by walking up the URL tree), such as articles/language and articles/libraries. Added /web.
* Updated /community, removing links to disused destinations.
* Made some other content changes to individual pages, including the spec page, /guides/libraries/futures-error-handling, ... I tried to restrain myself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants