fix: correct partId validation error message#814
Open
kimjune01 wants to merge 2 commits into
Open
Conversation
The error message for invalid SharedPartBuilder partId claims periods are allowed but hyphens aren't mentioned, while the regex allows hyphens but not periods.
Error message now matches actual validation rules: letters, numbers, underscore, and hyphen. Removes incorrect mention of dot character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedPartBuilderto correctly describe the allowed characters forpartId: letters, numbers,_, and-.(period) as an allowed character and referenced start/end rules that do not exist in the regexFixes #607
Test plan
-and does not mention.