-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom hostname and TLS options #2588
base: main
Are you sure you want to change the base?
Conversation
@bkonyi Hi, I reformatted the code. Should I update the dwds/CHANGELOG.md file too? |
Nope, I can disable that check for you! Overall this looks good to me, but ideally we'd add a test to make sure we don't regress in the future. Is that something you'd be willing to do? |
Hi @bkonyi, I added the tests. |
Fixed recent merge conflicts in the |
Will this be shipped in the next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding tests! Just a few comments.
Yes, this will be shipped with the next release of |
Awesome! I applied the requested changes, thanks for the suggestions! |
More than one month later, it seems to me no release has been made. Any chance of this happening soon? This bugfix is very important for me personally. |
Sorry for the delay @Wdestroier, this fell off my radar. LGTM! @nandoflorestan, once this lands @jyameo can publish a new version hopefully today or tomorrow. |
@Wdestroier can you please run |
Done @jyameo! |
Fixes #953.