Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotReloadSourcesUri parameter to FrontendServerDdcLibraryBundleProvider and publish DWDS 24.3.6 #2594

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Mar 3, 2025

#2584

During hot reload, a JSON file that contains the sources and libraries that need to be loaded and reloaded is expected. Before, Flutter tools was adding this script to the global window. It should instead be directly passed to the provider to be used later.

…ovider and publish DWDS 24.3.6

dart-lang#2584

During hot reload, a JSON file that contains the sources and libraries
that need to be loaded and reloaded is expected. Before, Flutter tools
was adding this script to the global window. It should instead be
directly passed to the provider to be used later.
@srujzs srujzs requested a review from jyameo March 3, 2025 18:11
@srujzs srujzs requested a review from nshahan March 3, 2025 19:50
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srujzs
Copy link
Contributor Author

srujzs commented Mar 4, 2025

Thanks Jessy!

@srujzs srujzs merged commit 8a8eaf1 into dart-lang:main Mar 4, 2025
47 of 48 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/6c770bf..c41b86b):
  c41b86b9  2025-03-12  Sam Rawlins  Remove reference to AugmentableElement, soon to be deleted (dart-lang/dartdoc#4016)
  5dbd403c  2025-03-10  Parker Lougheed  Utilize scss features in sidebar styles (dart-lang/dartdoc#4010)

http (https://github.com/dart-lang/http/compare/900da9f..001665e):
  001665e  2025-03-11  dependabot[bot]  Bump the github-actions group across 1 directory with 5 updates (dart-lang/http#1723)

i18n (https://github.com/dart-lang/i18n/compare/bdeec25..b09c822):
  b09c822  2025-03-12  Moritz  Dont check hashes on tag
  f681aa0  2025-03-12  Moritz  Fix artifact building workflows (dart-lang/i18n#956)
  2644c17  2025-03-11  Moritz  Small fixes to intl4x (dart-lang/i18n#955)
  6d680ad  2025-03-11  Copybara-Service  Merge pull request `#948` from kszczek:ignore-script-subtags
  88ab7a8  2025-02-20  Kamil Szczęk  feat(intl): ignore script subtags when canonicalizing locale strings

tools (https://github.com/dart-lang/tools/compare/d67cd00..9c53358):
  9c533582  2025-03-11  Parker Lougheed  [package_config] Prepare for 2.2.0 release (dart-lang/tools#2031)

webdev (https://github.com/dart-lang/webdev/compare/f485686..302b6db):
  302b6db6  2025-03-11  Srujan Gaddam  Remove reassemble invocation and publish 24.3.7 (dart-lang/webdev#2598)
  3e17660f  2025-03-11  Srujan Gaddam  [dwds] callServiceExtension should check all extensions and return kMethodNotFound when extension not found (dart-lang/webdev#2597)
  8f146a15  2025-03-05  Srujan Gaddam  Roll dwds to 24.3.7-wip and webdev to 3.7.2-wip (dart-lang/webdev#2596)
  2c1d147d  2025-03-04  Srujan Gaddam  Add pull request and id-token write permissions to publish.yaml (dart-lang/webdev#2595)
  8a8eaf1b  2025-03-04  Srujan Gaddam  Add hotReloadSourcesUri parameter to FrontendServerDdcLibraryBundleProvider and publish DWDS 24.3.6 (dart-lang/webdev#2594)

Change-Id: I9b7b16a0c8f62cd70e1eb76dea485bbef7b8be15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415300
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants