Skip to content

Conversation

@iinozemtsev
Copy link
Member

See b/449706507#comment3 for the detailed explanations.

Since the logic added as a fallback and only under isInternalBuild branch, I believe this change cannot have unexpected side effects.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

See b/449706507#comment3 for the detailed explanations.

Since the logic added as a fallback and only under `isInternalBuild` branch, I believe this change cannot have unexpected side effects.
@iinozemtsev iinozemtsev merged commit 56642b7 into dart-lang:main Nov 14, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants