Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix regression with pagination (DEV-4624) #320

Closed
wants to merge 1 commit into from

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Feb 24, 2025

Use axum_extra for optional query parameters

Regression was introduced when upgrading the dependencies: ade9581#diff-0068a256220ce90064179257fd65109c9e9ea5189144d78d22a029a8193c9a50

In a follow up PR I will create a tests the pagination.

Use axum_extra for optional query parameters
@seakayone seakayone changed the title fix: Fix pagination fix: Fix regression with pagination (DEV-4624) Feb 24, 2025
Copy link

linear bot commented Feb 24, 2025

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@seakayone seakayone marked this pull request as draft February 24, 2025 14:56
@seakayone seakayone self-assigned this Feb 24, 2025
@seakayone seakayone closed this Feb 24, 2025
@seakayone seakayone deleted the fix/fix-paging branch February 24, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants