Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): update code for eslint conformance #18

Conversation

cwadrupldijjit
Copy link
Contributor

What Changed?

  • .babelrc
    • fix quote types to make it conformant JSON
  • .eslintrc
    • update linter to not show errors where errors shouldn't be shown
  • .gitignore
    • begin ignoring the public directory--rely on built code
  • ComposeForm/*
    • beginnings of splitting up FormElements.jsx (will be addressed later)
  • PrefixedLink/index.jsx
    • add component to automatically prefix links in order to avoid having to do it manually
  • gatsby-node.js,
    ComposePage/index.jsx,
    Editor/index.jsx,
    FormElements.jsx,
    GitHubForm.jsx,
    gitHubHelper.js,
    localStorageHelper.js,
    ReadNext/index.jsx,
    SiteLinks/index.jsx,
    SiteNav/index.jsx,
    SitePage/index.jsx,
    SitePost/index.jsx,
    SiteSidebar/index.jsx
    • update files to eslint compliance
    • change repetetive field/element creation into data transformed the way you want
  • public/*
    • remove from git (built)

Issues Addressed:

no breaking changes--UI works exactly as originally implemented

changes:
  - .babelrc
    - fix quote types to make it conformant JSON
  - .eslintrc
    - update linter to not show errors where errors shouldn't be shown
  - .gitignore
    - begin ignoring the public directory--rely on built code
  - ComposeForm/*
    - beginnings of splitting up FormElements.jsx (will be addressed later)
  - PrefixedLink/index.jsx
    - add component to automatically prefix links in order to avoid having to do it manually
  - gatsby-node.js,
        ComposePage/index.jsx,
        Editor/index.jsx,
        FormElements.jsx,
        GitHubForm.jsx,
        gitHubHelper.js,
        localStorageHelper.js,
        ReadNext/index.jsx,
        SiteLinks/index.jsx,
        SiteNav/index.jsx,
        SitePage/index.jsx,
        SitePost/index.jsx,
        SiteSidebar/index.jsx
    - update files to eslint compliance
    - change repetetive field/element creation into data transformed the way you want
  - public/*
    - remove from git (built)

issues addressed:
  - dashcommunity#14

no breaking changes--UI works exactly as originally implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants