[PLEASE REVIEW] #17 Auto submit token #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2017 22:55
changes:
- .babelrc
- fix quote types to make it conformant JSON
- .eslintrc
- update linter to not show errors where errors shouldn't be shown
- .gitignore
- begin ignoring the public directory--rely on built code
- ComposeForm/*
- beginnings of splitting up FormElements.jsx (will be addressed later)
- PrefixedLink/index.jsx
- add component to automatically prefix links in order to avoid having to do it manually
- gatsby-node.js,
ComposePage/index.jsx,
Editor/index.jsx,
FormElements.jsx,
GitHubForm.jsx,
gitHubHelper.js,
localStorageHelper.js,
ReadNext/index.jsx,
SiteLinks/index.jsx,
SiteNav/index.jsx,
SitePage/index.jsx,
SitePost/index.jsx,
SiteSidebar/index.jsx
- update files to eslint compliance
- change repetetive field/element creation into data transformed the way you want
- public/*
- remove from git (built)
issues addressed:
- dashcommunity#14
no breaking changes--UI works exactly as originally implemented
changes:
- firebaseHelper.js
- add helper to manage auth
- index.jsx
- create module file to import and export necessary components
- initializeFirebase.js
- add file to create the firebase connection
- gitHubHelpers.js
- import auth into file to test if it wiill work
issues addressed:
- dashcommunity#15
no breaking changes; auth not yet fully integrated into the project
changes:
- firebaseHelper.js
- assign token, user, and credential to auth object
- add to local storage
- add getAuthObj function to get and deserialize authObj
- ComposePage/index.jsx
- import newly created login button and add logic to change whether it shows the action form or if it shows the login button
- ComposeFormElements/index.jsx
- add new login button component to exports
- login-button.css
- add styles to make sure that it looks non-gaggy
- LoginButton.jsx
- create form where the login button will live and call submit function when login is successful
- package.json
- ensure that the browser opens to localhost (so firebase auth will work)
issues addressed:
- dashcommunity#16
no breaking changes--only adds annoyance to the form, not convenience so far
changes: - add helper functions to deal with username - firebase auth helper uses authObj instead of exporting individual members - clean up slightly the form elements - add username prepopulation to the redux form (dosn't work at the moment) - automatically grab the token when submitting the form issues addressed: - dashcommunity#17 no breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Issues Addressed: