-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable test_all, fix _aliases.__all__
#286
Conversation
This reverts commit 5473d84.
0e339fc
to
9bb1021
Compare
I think I might want to merge this PR sooner than later, if only to restore the state of the tests and make the CI green by default. Please speak up if you want some more time to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Evgeni! Just one comment
Co-authored-by: Evgeni Burovski <[email protected]>
Okay, let's merge this. Thanks Aaron for weighing in in #283, thanks Lucas for the review. |
This looks good to me. Better make sure all tests are actually run on CI! |
closes gh-283
test_all
common._aliases.__all__
which was wrongSo the
__all__
list was wrong for a while, but it was not caught be tests because:$ pytest tests/
locallysys.modules
. So if an implementation module is not imported, it's not checked: this was the case withcommon._aliases
until BUG: torch: fixresult_type
with python scalars #277 added an unrelated test.