- 
                Notifications
    
You must be signed in to change notification settings  - Fork 38
 
Drop Python 3.9; test on Python 3.13; drop NumPy 1.21; skip CUDA install #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      38d4d56
              
                Drop Python 3.9; Test on Python 3.13; drop NumPy 1.21; skip CUDA install
              
              
                crusaderky 221ff01
              
                xfails
              
              
                crusaderky 3bc8ffa
              
                clip
              
              
                crusaderky b73e179
              
                revert vecdot on np-dev
              
              
                crusaderky fd06e11
              
                Remove numpy-skips
              
              
                crusaderky 4bab6fb
              
                torch fix
              
              
                crusaderky aceca8c
              
                Dummy files
              
              
                crusaderky ebeaca2
              
                revert vecdot
              
              
                crusaderky f71a31d
              
                disable fail-fast
              
              
                crusaderky 107c5a5
              
                Revert "clip"
              
              
                crusaderky e727b5d
              
                reverts
              
              
                crusaderky 1297e56
              
                Add note
              
              
                crusaderky 6901fc0
              
                xfail linspace and where
              
              
                crusaderky File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              This file was deleted.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: Array API Tests (NumPy 1.22) | ||
| 
     | 
||
| on: [push, pull_request] | ||
| 
     | 
||
| jobs: | ||
| array-api-tests-numpy-1-22: | ||
| uses: ./.github/workflows/array-api-tests.yml | ||
| with: | ||
| package-name: numpy | ||
| package-version: '== 1.22.*' | ||
| xfails-file-extra: '-1-22' | ||
| python-versions: '[''3.10'']' | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -36,23 +36,16 @@ deviations from the standard should be noted: | |
| 50](https://numpy.org/neps/nep-0050-scalar-promotion.html) and | ||
| https://github.com/numpy/numpy/issues/22341) | ||
| 
     | 
||
| - `asarray()` does not support `copy=False`. | ||
| 
     | 
||
| - Functions which are not wrapped may not have the same type annotations | ||
| as the spec. | ||
| 
     | 
||
| - Functions which are not wrapped may not use positional-only arguments. | ||
| 
     | 
||
| The minimum supported NumPy version is 1.21. However, this older version of | ||
| The minimum supported NumPy version is 1.22. However, this older version of | ||
| NumPy has a few issues: | ||
| 
     | 
||
| - `unique_*` will not compare nans as unequal. | ||
| - `finfo()` has no `smallest_normal`. | ||
| - No `from_dlpack` or `__dlpack__`. | ||
| - `argmax()` and `argmin()` do not have `keepdims`. | ||
| - `qr()` doesn't support matrix stacks. | ||
| - `asarray()` doesn't support `copy=True` (as noted above, `copy=False` is not | ||
| supported even in the latest NumPy). | ||
| - Type promotion behavior will be value based for 0-D arrays (and there is no | ||
| `NPY_PROMOTION_STATE=weak` to disable this). | ||
| 
     | 
||
| 
        
          
        
         | 
    @@ -72,8 +65,8 @@ version. | |
| attribute in the spec. Use the {func}`~.size()` helper function as a | ||
| portable workaround. | ||
| 
     | 
||
| - PyTorch does not have unsigned integer types other than `uint8`, and no | ||
| attempt is made to implement them here. | ||
| - PyTorch has incomplete support for unsigned integer types other | ||
| than `uint8`, and no attempt is made to implement them here. | ||
| 
     | 
||
| - PyTorch has type promotion semantics that differ from the array API | ||
| specification for 0-D tensor objects. The array functions in this wrapper | ||
| 
        
          
        
         | 
    @@ -100,8 +93,6 @@ version. | |
| - As with NumPy, type annotations and positional-only arguments may not | ||
| exactly match the spec for functions that are not wrapped at all. | ||
| 
     | 
||
| The minimum supported PyTorch version is 1.13. | ||
| 
     | 
||
| (jax-support)= | ||
| ## [JAX](https://jax.readthedocs.io/en/latest/) | ||
| 
     | 
||
| 
          
            
          
           | 
    @@ -131,8 +122,6 @@ For `linalg`, several methods are missing, for example: | |
| - `matrix_rank` | ||
| Other methods may only be partially implemented or return incorrect results at times. | ||
| 
     | 
||
| The minimum supported Dask version is 2023.12.0. | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not advertise what you don't test. Also helplessly obsolete; we know for sure that less than 2024.9.0 won't work.  | 
||
| 
     | 
||
| (sparse-support)= | ||
| ## [Sparse](https://sparse.pydata.org/en/stable/) | ||
| 
     | 
||
| 
          
            
          
           | 
    ||
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not advertise what you don't test.