ENH: apply_where (migrate lazywhere from scipy)
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Feb 10, 2025
Comment on lines
+182
to
+158
| if is_jax_namespace(xp): | ||
| # jax.jit does not support assignment by boolean mask | ||
| return xp.where(cond, f1(*args), f2(*args) if f2 is not None else fill_value) |
There was a problem hiding this comment.
JAX-on-dask is currently unsupported by Dask. This is here and not much higher above only for this reason.
We'll need to add explicit unit tests when it lands in the future.
crusaderky
commented
Feb 10, 2025
| ncond = ~cond | ||
| temp2 = f2(*(arr[ncond] for arr in args)) | ||
| out = xp.empty(cond.shape, dtype=dtype, device=device) | ||
| out = at(out, ncond).set(temp2) |
There was a problem hiding this comment.
JAX doesn't benefit from this at, but Sparse will (eventually)
crusaderky
force-pushed
the
lazywhere
branch
from
41e26ad to
f8a633e
Compare
rgommers
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Thanks @crusaderky. Overall looks good, a few comments. Didn't test locally yet, will do once this is no longer Draft.
crusaderky
force-pushed
the
lazywhere
branch
5 times, most recently
from
2d199dd to
0b7fce1
Compare
crusaderky
changed the title
apply_where (migrate lazywhere from scipy)apply_where (migrate lazywhere from scipy)
crusaderky
changed the title
apply_where (migrate lazywhere from scipy)apply_where (migrate lazywhere from scipy)
crusaderky
force-pushed
the
lazywhere
branch
from
bf1e1e6 to
b686fe3
Compare
crusaderky
commented
Feb 19, 2025
crusaderky
commented
Feb 19, 2025
crusaderky
commented
Feb 19, 2025
mdhaber
reviewed
Feb 19, 2025
crusaderky
changed the title
apply_where (migrate lazywhere from scipy)apply_where (migrate lazywhere from scipy)
crusaderky
force-pushed
the
lazywhere
branch
4 times, most recently
from
c9be347 to
e307525
Compare
crusaderky
force-pushed
the
lazywhere
branch
2 times, most recently
from
71aebee to
ecc4931
Compare
This was referenced Mar 6, 2025
crusaderky
force-pushed
the
lazywhere
branch
2 times, most recently
from
f027734 to
fed0d81
Compare
lucascolley
reviewed
Mar 13, 2025
mdhaber
reviewed
Mar 14, 2025
crusaderky
force-pushed
the
lazywhere
branch
2 times, most recently
from
c3c6337 to
b3808e7
Compare
lucascolley
reviewed
Mar 17, 2025
lucascolley
reviewed
Mar 18, 2025
lucascolley
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
would you like to move the discussion at #141 (comment) to an issue somewhere?
|
@lucascolley all comments have been addressed |
NeilGirdhar
pushed a commit
to NeilGirdhar/array-api-extra
that referenced
this pull request
Apr 2, 2025
* ENH: apply_where (migrate _lazywhere from scipy) * Code review * merge main * tweak sparse skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14.
scipy._lib._utils.lazywhere, with revised UI and added support for jax.jit and Dask.