New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop skipping test_divide for complex inputs #306

Merged

asmeurer merged 1 commit into data-apis:master from ev-br:elementwise_tests

Nov 18, 2024

Member

ev-br commented Nov 16, 2024

Address the test_divide (no complex numbers testing) part of #301

Locally tests seem to pass, so I actually wonder what was meant by the TODO comment.


          stop skipping test_divide for complex inputs

24e6819

Member

asmeurer commented Nov 18, 2024

Not sure. It was added in ff865bc. It's possible my fix at aba096e using cmath instead of math was all that was needed.

asmeurer merged commit 393b69b into data-apis:master

4 checks passed

ev-br mentioned this pull request

Incomplete tests #301

Open

36 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet